Skip to content

feat: Add support to build automatically npm dependencies #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maintux wants to merge 9 commits into from
Closed

feat: Add support to build automatically npm dependencies #292

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ab140a5
add support to build automatically npm dependencies, with docker sup…
Mar 26, 2022
c08ed1d
Add missing parameter to npm_requirements_step function
Mar 26, 2022
ba5d37a
fix typo
Mar 26, 2022
993a1e2
update README and add some example for npm build
Mar 26, 2022
ccb2007
fix README
Mar 26, 2022
6fd5442
Apply suggestions from code review
antonbabenko Mar 26, 2022
dba58e7
minor fixes to npm examples
Mar 26, 2022
d73929f
Merge branch 'npm-support' of github.com:maintux/terraform-aws-lambda…
Mar 26, 2022
3bd5d6d
fix README
Mar 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add missing parameter to npm_requirements_step function
  • Loading branch information
Massimo Maino committed Mar 26, 2022
commit c08ed1d4082e6dde138b50bdf8c2761b60fa5474
4 changes: 2 additions & 2 deletions package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,7 +660,7 @@ def pip_requirements_step(path, prefix=None, required=False, tmp_dir=None):
step('pip', runtime, requirements, prefix, tmp_dir)
hash(requirements)

def npm_requirements_step(path, prefix=None, required=False):
def npm_requirements_step(path, prefix=None, required=False, tmp_dir=None):
requirements = path
if os.path.isdir(path):
requirements = os.path.join(path, 'package.json')
Expand All @@ -669,7 +669,7 @@ def npm_requirements_step(path, prefix=None, required=False):
raise RuntimeError(
'File not found: {}'.format(requirements))
else:
step('npm', runtime, requirements, prefix, None)
step('npm', runtime, requirements, prefix, tmp_dir)
hash(requirements)

def commands_step(path, commands):
Expand Down