Skip to content

Conversation

@niranjan94
Copy link
Contributor

@niranjan94 niranjan94 commented Aug 10, 2020

Description

Resolves #44

Motivation and Context

To support the new file_system_config which allows Lambdas to have EFS file systems mounted.

Breaking Changes

No breaking changes.

How Has This Been Tested?

  • Tested on a project that requires file_system_config.

  • Tested Plan & Apply. Works as expected.

     Terraform v0.12.29
     + provider.aws v2.70.0
     + provider.external v1.2.0
     + provider.local v1.4.0
     + provider.null v2.1.2
    
     Terraform v0.13.0
     + provider registry.terraform.io/hashicorp/aws v2.70.0
     + provider registry.terraform.io/hashicorp/external v1.2.0
     + provider registry.terraform.io/hashicorp/local v1.4.0
     + provider registry.terraform.io/hashicorp/null v2.1.2
    

@cageyv
Copy link

cageyv commented Aug 11, 2020

@niranjan94 , can you test it on aws 3.0 or 3.1?
It would be better if there was an opportunity to immediately switch to support for a new provider.
I also recommend using the new terraform 0.13.0 for tests.
This version is already allowed in the module and will probably be used automatically by others.

@niranjan94
Copy link
Contributor Author

@cageyv good point. I'll test it out and post my updates here.

@antonbabenko
Copy link
Member

@niranjan94 Thanks for this PR!

I have just added support for AWS provider v3 to this module and released v1.18.0, so if you have time, please finish this PR by adding a new example into examples folder with all required resources for EFS, and update formatting and documentation by running pre-commit run -a.

@niranjan94
Copy link
Contributor Author

@antonbabenko thanks for your review. Have updated the PR with the requested changes.

@antonbabenko antonbabenko changed the title Add support for EFS File System Config feat: Add support for EFS File System Config Aug 14, 2020
@antonbabenko antonbabenko merged commit 05c5306 into terraform-aws-modules:master Aug 14, 2020
@antonbabenko
Copy link
Member

Thanks, @niranjan94 !

v1.19.0 has been just released. I have updated examples and added a note that Terraform 0.13 is recommended for EFS example to work.

@niranjan94 niranjan94 deleted the feature/file-system-config branch August 15, 2020 14:29
@niranjan94
Copy link
Contributor Author

@antonbabenko thanks a lot for quick merge + release 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add efs file system support for lambda function

3 participants