Skip to content

feat: Respect the package-lock.json for a NodeJS Lambda function #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonbabenko merged 3 commits into from
Aug 22, 2025
+205 −8
Merged

feat: Respect the package-lock.json for a NodeJS Lambda function #681

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc9be0a
Reformat package.py with ruff before making changes
May 20, 2025
5b70e1d
feat: Respect the package-lock.json for a NodeJS Lambda function
May 20, 2025
ba90dd0
Merge branch 'master' into npm_lock_file
antonbabenko Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Reformat package.py with ruff before making changes
  • Loading branch information
Amadeusz Żołnowski committed May 20, 2025
commit cc9be0ae3a8293bb5277910158aa71721bf80778
8 changes: 4 additions & 4 deletions package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1088,7 +1088,7 @@ def install_pip_requirements(query, requirements_file, tmp_dir):
ok = True
elif docker_file or docker_build_root:
raise ValueError(
"docker_image must be specified " "for a custom image future references"
"docker_image must be specified for a custom image future references"
)

working_dir = os.getcwd()
Expand All @@ -1108,7 +1108,7 @@ def install_pip_requirements(query, requirements_file, tmp_dir):
elif OSX:
# Workaround for OSX when XCode command line tools'
# python becomes the main system python interpreter
os_path = "{}:/Library/Developer/CommandLineTools" "/usr/bin".format(
os_path = "{}:/Library/Developer/CommandLineTools/usr/bin".format(
os.environ["PATH"]
)
subproc_env = os.environ.copy()
Expand Down Expand Up @@ -1390,7 +1390,7 @@ def install_npm_requirements(query, requirements_file, tmp_dir):
ok = True
elif docker_file or docker_build_root:
raise ValueError(
"docker_image must be specified " "for a custom image future references"
"docker_image must be specified for a custom image future references"
)

log.info("Installing npm requirements: %s", requirements_file)
Expand Down Expand Up @@ -1649,7 +1649,7 @@ def prepare_command(args):
timestamp = timestamp_now_ns()
was_missing = True
else:
timestamp = "<WARNING: Missing lambda zip artifacts " "wouldn't be restored>"
timestamp = "<WARNING: Missing lambda zip artifacts wouldn't be restored>"

# Replace variables in the build command with calculated values.
build_data = {
Expand Down