feat: add gRPC and HTTPS ports to Consul array #223
Conversation
Port 8400 for CLI disappeared along the way. In came 8501 for HTTPS and 8502 for gRPC.
feat: add gRPC and HTTPS ports to Consul array
|
@bryantbiggs When I clicked "Update branch" on the PR the commit 779c0bb is pushed to the |
# [4.7.0](v4.6.1...v4.7.0) (2021-11-25) ### Features * add gRPC and HTTPS ports to Consul array ([#223](#223)) ([914bfad](914bfad))
|
This PR is included in version 4.7.0 🎉 |
|
@antonbabenko ya we could add in a hacky repo name check. however, unless users have the GH token set as a secret and as the same name, nothing will happen. |
|
Ok, in the future let's add such a check to not even trigger anything. I propose that we track such issues somewhere in meta repository and apply them at once a bit later. It is good that secrets are not floating around from the main repo to forks :) |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
3 participants
Description
Default ports in Consul have changed over time.
Motivation and Context
In order to correctly generate rules for a Consul security group, this should be considered.
Breaking Changes
None that I know of.
How Has This Been Tested?