Skip to content

Conversation

@arushi019
Copy link
Contributor

@tcr @Frijol @tikurahul @reconbot Please review this pull request. Thanks :)

@tessel-bot
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @tcr (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

WWW.md Outdated
*slackin.tessel.io
*start.tessel.io
*t1-start.tessel.io
*crash-reporter.tessel.io
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, should have been more clear.

http://crash-reporter.tessel.io is running on Google App Engine. You should probably add a separate section for that.

@Frijol
Copy link
Member

Frijol commented Jul 25, 2018

Thanks for the PR, team! A couple of notes on contribution style:

  • In a PR that's directly related to an issue, make sure to link to that issue in the PR! Paste a link like so Better document our web services use #345 in a comment; Github will create cross-linking so visitors to the issue see that it's being addressed
  • If your commit message is "fixes (issue link)", Github will automatically close that issue when your PR is accepted! This is encouraged
  • You have three different commits for this PR, but their commit messages are essentially the same. Any time you make a commit, your commit message should show why this commit in particular was needed– even if it's "adding (thing) that I forgot in previous commit". Can you please either amend the commits, or squash them? ("amend" and "squash" are both git commands, and your coaches should be able to help, as this is challenging for most people the first several times)

Just one note on the commit itself: you need a space between "*" and the list item, or it won't be a bulleted list in Markdown.

@Frijol Frijol self-requested a review July 25, 2018 18:06
Copy link
Member

@Frijol Frijol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see previous comment (whoops, note on my Github style: I should have left that comment in this review instead)

@arushi019
Copy link
Contributor Author

Hi!
I have made changes as per the review by @Frijol. Kindly review the new commits in this pull request @Frijol @tikurahul @tcr @reconbot .
Issue: #345
Thanks!

Copy link
Member

@Frijol Frijol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@Frijol Frijol merged commit ab56355 into tessel:master Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants