-
Notifications
You must be signed in to change notification settings - Fork 75
Team DelSquared (RGSoC '18): Added services hosted on Dokku #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @tcr (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
WWW.md
Outdated
| *slackin.tessel.io | ||
| *start.tessel.io | ||
| *t1-start.tessel.io | ||
| *crash-reporter.tessel.io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, should have been more clear.
http://crash-reporter.tessel.io is running on Google App Engine. You should probably add a separate section for that.
|
Thanks for the PR, team! A couple of notes on contribution style:
Just one note on the commit itself: you need a space between "*" and the list item, or it won't be a bulleted list in Markdown. |
Frijol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see previous comment (whoops, note on my Github style: I should have left that comment in this review instead)
Issue link : tessel#345 Introduced changes as mentioned in review [Team DelSquared RGSoC '18]
Frijol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
@tcr @Frijol @tikurahul @reconbot Please review this pull request. Thanks :)