Test for ThrowFromClientLoggerCheck.java (Azure#5317)

* remove java code isImple check but move to suppression and add only check for public class for external Dependency check

* test for ThrowFromClientLoggerCheck

* add skip check on static methods, static class, and construcoor

eng/code-quality-reports/src/test/java/com/azure/tools/checkstyle/checks/ThrowFromClientLoggerCheckTest.java

@@ -0,0 +1,46 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+package com.azure.tools.checkstyle.checks;
+
+import com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport;
+import com.puppycrawl.tools.checkstyle.Checker;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+
+public class ThrowFromClientLoggerCheckTest extends AbstractModuleTestSupport {
+
+    private static final String DIRRECT_THROW_ERROR_MESSAGE = "Directly throwing an exception is disallowed. Must "
+        + "throw through 'ClientLogger' API, either of 'logger.logExceptionAsError' or 'logger.logExceptionAsWarning' "
+        + "where 'logger' is type of ClientLogger from Azure Core package.";
+
+    private Checker checker;
+
+    @Before
+    public void prepare() throws Exception {
+        checker = createChecker(createModuleConfig(ThrowFromClientLoggerCheck.class));
+    }
+
+    @After
+    public void cleanup() {
+        checker.destroy();
+    }
+
+    @Override
+    protected String getPackageLocation() {
+        return "com/azure/tools/checkstyle/checks/ThrowFromClientLoggerCheck";
+    }
+
+    @Test
+    public void directThrowExceptionTestData() throws Exception {
+        String[] expected = {
+            expectedErrorMessage(12, 9, String.format(DIRRECT_THROW_ERROR_MESSAGE))
+        };
+        verify(checker, getPath("DirectThrowExceptionTestData.java"), expected);
+    }
+
+    private String expectedErrorMessage(int line, int column, String errorMessage) {
+        return String.format("%d:%d: %s", line, column, errorMessage);
+    }
+}

eng/code-quality-reports/src/test/resources/com/azure/tools/checkstyle/checks/ThrowFromClientLoggerCheck/DirectThrowExceptionTestData.java

@@ -0,0 +1,29 @@
+import com.azure.core.util.logging.ClientLogger;
+
+public class DirectThrowExceptionTestData {
+    private final ClientLogger logger = new ClientLogger(DirectThrowExceptionTestData.class);
+
+    // Skip check on constructor
+    DirectThrowExceptionTestData() {
+        throw new RuntimeException("Error Messages.");
+    }
+
+    public void directThrowException () {
+        throw new RuntimeException("Error Messages.");
+    }
+
+    public void correctThrowException() {
+        throw logger.logExceptionAsWarning(Exceptions.propagate(new IllegalStateException("Error Messages")));
+    }
+
+    public static skipCheckOnStaticMethod() {
+        throw new RuntimeException("Error Messages.");
+    }
+
+    // Skip check on static class
+    static class SkipCheckOnStaticClass {
+        public void directThrowException () {
+            throw new RuntimeException("Error Messages.");
+        }
+    }
+}