Skip to content

Conversation

@eddumelendez
Copy link
Member

What does this PR do?

This PR adds an utility SocatContainer that can serve as a proxy to other containers.

Why is it important?

  • connect to the Docker Model Runner
  • Testcontainers for Java also use it at compose implementation, making service ports available at random ports instead of the ones defined at compose definition.

Related issues

N/A

@netlify
Copy link

netlify bot commented Apr 2, 2025

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 9d488b6
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/67ee70e66a44e80008d6e93a
😎 Deploy Preview https://deploy-preview-1416--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Eddú, thanks for the PR. While reviewing, I noticed two issues. One of them seems like a bug we hadn't caught before.

  • Usually, the builders don't need to handle merging any values. That's automatically done by the underlying implementation. It looks like a constraint prevented that for the SocatConfiguration class. See my changes in BuildConfiguration.
  • I think we can remove exposing the port 8080 for the hello world container. I think all traffic should go through Socat and the Docker network.

If you're good with these changes, I'm happy to merge the PR.

@HofmeisterAn
Copy link
Collaborator

It looks like there is an issue pulling images from icr.io, probably a temporary issue.

@HofmeisterAn HofmeisterAn added the enhancement New feature or request label Apr 3, 2025
@HofmeisterAn HofmeisterAn changed the title Add Socat container implementation feat: Add Socat container implementation Apr 3, 2025
@eddumelendez
Copy link
Member Author

Hi @HofmeisterAn, thank you so much for all the improvements! learned so much by submitting this PR. 🚀

@HofmeisterAn HofmeisterAn merged commit 594ae5d into develop Apr 3, 2025
147 of 188 checks passed
@HofmeisterAn HofmeisterAn deleted the socat-container branch April 3, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants