Skip to content

fix(pointer): change selection before dispatching focus #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ph-fritsche merged 2 commits into from
Mar 31, 2022
Merged

fix(pointer): change selection before dispatching focus #895

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40e18a9
fix(pointer): change selection before dispatching `focus`
ph-fritsche Mar 31, 2022
822debf
update tests
ph-fritsche Mar 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(pointer): change selection before dispatching focus
  • Loading branch information
@ph-fritsche
ph-fritsche committed Mar 31, 2022
commit 40e18a9749f4c9661d3b287b14e5cdaabe79017a
12 changes: 5 additions & 7 deletions src/pointer/pointerPress.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,13 +266,6 @@ function mousedownDefaultBehavior({
node?: Node
offset?: number
}) {
// The closest focusable element is focused when a `mousedown` would have been fired.
// Even if there was no `mousedown` because the element was disabled.
// A `mousedown` that preventsDefault cancels this though.
focus(target)

// TODO: What happens if a focus event handler interfers?

// An unprevented mousedown moves the cursor to the closest character.
// We try to approximate the behavior for a no-layout environment.
if (!targetIsDisabled) {
Expand Down Expand Up @@ -326,6 +319,11 @@ function mousedownDefaultBehavior({
selection.addRange(range.cloneRange())
}
}

// The closest focusable element is focused when a `mousedown` would have been fired.
// Even if there was no `mousedown` because the element was disabled.
// A `mousedown` that preventsDefault cancels this though.
focus(target)
}

function getTextRange(
Expand Down