Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: thanos-io/thanos
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c95fd62
Choose a base ref
...
head repository: thanos-io/thanos
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 001bbf7
Choose a head ref
  • 14 commits
  • 36 files changed
  • 8 contributors

Commits on May 18, 2020

  1. compact: add label when no labels left after deduplication (#2526) 

    * add --deduplication.label-if-empty

Signed-off-by: Alexander Ryabov <alexander.ryabov@jetbrains.com>

* add test

Signed-off-by: Alexander Ryabov <alexander.ryabov@jetbrains.com>

* add changelog

Signed-off-by: Alexander Ryabov <alexander.ryabov@jetbrains.com>

* use replica-label

Signed-off-by: Alexander Ryabov <alexander.ryabov@jetbrains.com>

* add Warn log

Signed-off-by: Alexander Ryabov <alexander.ryabov@jetbrains.com>

Co-authored-by: Alexander Ryabov <alexander.ryabov@jetbrains.com>
    @sepich
    sepich and sepich authored May 18, 2020
    Configuration menu
    Copy the full SHA
    1859833 View commit details
    Browse the repository at this point in the history

  2. Rename caching_bucket yaml fields (#2625) 

    Signed-off-by: Ranjith Kumar <ranjith.dakshana2015@gmail.com>
    @ranjithkumar007
    ranjithkumar007 authored May 18, 2020
    Configuration menu
    Copy the full SHA
    c012e9c View commit details
    Browse the repository at this point in the history

  3. Added logging for dns resolution error in the Query component as well (… 

    …#2525)

* Added logging for dns resolution error in the Query component as well

Signed-off-by: Yash <yashrsharma44@gmail.com>

Nitpicking

Signed-off-by: Yash <yashrsharma44@gmail.com>

More nitpicking

Signed-off-by: Yash <yashrsharma44@gmail.com>

Removed the errorlist from lock scope for faster access

Signed-off-by: Yash <yashrsharma44@gmail.com>

Added tsdb.MultiError for error handling

Signed-off-by: Yash <yashrsharma44@gmail.com>

Fixed some import issues

Signed-off-by: Yash <yashrsharma44@gmail.com>

Fixed linting

Signed-off-by: Yash <yashrsharma44@gmail.com>

Changelog

Signed-off-by: Yash <yashrsharma44@gmail.com>

Linting issues

Signed-off-by: Yash <yashrsharma44@gmail.com>

More linting issues

Signed-off-by: Yash <yashrsharma44@gmail.com>

fixed import error

Signed-off-by: Yash <yashrsharma44@gmail.com>

Reverted some changes

Signed-off-by: Yash <yashrsharma44@gmail.com>

Added some more error checks

Signed-off-by: Yash <yashrsharma44@gmail.com>

Fixed some failing tests

Signed-off-by: Yash <yashrsharma44@gmail.com>

Linting

Signed-off-by: Yash <yashrsharma44@gmail.com>

Removed extra error param for logging

Signed-off-by: Yash <yashrsharma44@gmail.com>

Changelog modification

Signed-off-by: Yash <yashrsharma44@gmail.com>

Fixed unused variable

Signed-off-by: Yash <yashrsharma44@gmail.com>

Logged failed dns resolution in the memcached_client

Signed-off-by: Yash <yashrsharma44@gmail.com>

Changed the errorList to errs

Signed-off-by: Yash <yashrsharma44@gmail.com>

Changed concrete error type to primitive one

Signed-off-by: Yash <yashrsharma44@gmail.com>

Added logging of dns resolution failure in `http.go`
Changed the error message in the `memcached_client.go`

Signed-off-by: Yash <yashrsharma44@gmail.com>

Removed logging of errors in . Now it would return error list, which is to be handled by the receiver

Signed-off-by: Yash <yashrsharma44@gmail.com>

Removed Err() method

Signed-off-by: Yash <yashrsharma44@gmail.com>

Fixed import errors

Signed-off-by: Yash <yashrsharma44@gmail.com>

Removed extra variables

Signed-off-by: Yash <yashrsharma44@gmail.com>

Linting

Signed-off-by: Yash <yashrsharma44@gmail.com>

Check to ensure that return error if list of error is non-empty

Signed-off-by: Yash <yashrsharma44@gmail.com>

Modified tests of provider_test.go

Signed-off-by: Yash <yashrsharma44@gmail.com>

more checks

Signed-off-by: Yash <yashrsharma44@gmail.com>

* Remove print statement

Signed-off-by: Yash <yashrsharma44@gmail.com>

* Instead of logging the error and then returning it, just return the error

Signed-off-by: Yash <yashrsharma44@gmail.com>

* Error check for resolve method in rule.go

Signed-off-by: Yash <yashrsharma44@gmail.com>

* Added more useful error message

Signed-off-by: Yash <yashrsharma44@gmail.com>

* Modified errs.Err() so that it returns error if found else returns nil

Signed-off-by: Yash <yashrsharma44@gmail.com>

* Linting

Signed-off-by: Yash <yashrsharma44@gmail.com>

* Added missing imports

Signed-off-by: Yash <yashrsharma44@gmail.com>

* Fixed some changelog issues

Signed-off-by: Yash <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 authored May 18, 2020
    Configuration menu
    Copy the full SHA
    960563c View commit details
    Browse the repository at this point in the history

Commits on May 19, 2020

  1. Soft cut changelog on master to indicate new release being in progres… 

    …s. (#2627)

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
    @bwplotka
    bwplotka authored May 19, 2020
    Configuration menu
    Copy the full SHA
    ad79cc7 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2020

  1. receive: Only wait for write quorum (#2621) 

    This patch modifies receive replication slightly, in that it doesn't
always wait for all requests to complete anymore. If quorum amount of
replication requests were successful it now does not wait for the
remaining request to finish as it's not necessary to reach quorum
anymore. In error cases where quorum is not reached, it still continues
to wait for all requests to finish in an attempt to return a quorum
error.

Additionally this patch moves log lines printed in the parallelize
requests function to debug logging. Calling functions already print the
resulting error(s), so this was previously just noise, even in cases
where requests actually succeeded.

Signed-off-by: Frederic Branczyk <fbranczyk@gmail.com>
    @brancz
    brancz authored May 20, 2020
    Configuration menu
    Copy the full SHA
    929864c View commit details
    Browse the repository at this point in the history

  2. Fixed panic in compactor (#2632) 

    Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci
    pracucci authored May 20, 2020
    Configuration menu
    Copy the full SHA
    8064791 View commit details
    Browse the repository at this point in the history

  3. mixin: Dynamically alert on forward request depending on replication … 

    …factor (#2624)

* Adjust forward request error alert dynamically depending on replication factor

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>

* Adjust forward request error alert dynamically depending on replication factor

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>

* Adjust forward request error alert dynamically depending on replication factor

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>

* Address review issues

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
    @kakkoyun
    kakkoyun authored May 20, 2020
    Configuration menu
    Copy the full SHA
    8bdd15e View commit details
    Browse the repository at this point in the history

  4. Fix inconsistent cache backend types for store (#2634) 

    Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
    @kakkoyun
    kakkoyun authored May 20, 2020
    Configuration menu
    Copy the full SHA
    22385d8 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2020

  1. Added Attributes() to BucketReader 

    Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci
    pracucci committed May 21, 2020
    Configuration menu
    Copy the full SHA
    65aa0d7 View commit details
    Browse the repository at this point in the history

  2. Removed ObjectSize() from BucketReader 

    Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci
    pracucci committed May 21, 2020
    Configuration menu
    Copy the full SHA
    784efdd View commit details
    Browse the repository at this point in the history

  3. Added copyright header 

    Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci
    pracucci committed May 21, 2020
    Configuration menu
    Copy the full SHA
    0be28e2 View commit details
    Browse the repository at this point in the history

  4. Fixes after rebase 

    Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci
    pracucci committed May 21, 2020
    Configuration menu
    Copy the full SHA
    e8b17f5 View commit details
    Browse the repository at this point in the history

  5. Fixed config 

    Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci
    pracucci committed May 21, 2020
    Configuration menu
    Copy the full SHA
    e7d0d6d View commit details
    Browse the repository at this point in the history

  6. Addressed review comments 

    Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci
    pracucci committed May 21, 2020
    Configuration menu
    Copy the full SHA
    001bbf7 View commit details
    Browse the repository at this point in the history
Loading