Remove references to 'bzr' as it is no longer required#1137
Merged
brancz merged 1 commit intothanos-io:masterfrom May 10, 2019
wbh1:remove-bzr
Merged
Remove references to 'bzr' as it is no longer required#1137brancz merged 1 commit intothanos-io:masterfrom wbh1:remove-bzr
brancz merged 1 commit intothanos-io:masterfrom
wbh1:remove-bzr
Conversation
Member
|
Awesome! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
After bumping the Prometheus version to 2.8.1 in #1009,
bzrshould no longer a build requirement. (This was addressed in prometheus/prometheus#5378). As such, it doesn't make much sense to keep it as a requirement in theMakefileanymore :)The only remaining package with a dependency that required
bzrwasgithub.amrom.workers.dev/improbable-eng/thanos/pkg/clusterbecause it depended on v0.1.0 ofgithub.amrom.workers.dev/hashicorp/memberlist. I've bumped this dependency to v0.1.3 which no longer has a dependency that needsbzr.For historical reference, the
bzrdependency was previously discussed in #868 and #948Verification
I have verified that Thanos builds successfully still on MacOS. I could use someone to test a Linux build if they feel inclined, though. (Make sure you clean out your
go modpackage cache first)All tests passed (I skipped e2e tests for store buckets, but those should not be affected).
Before, there were two modules that needed
bzrinstalled:Now: