Conversation
Member
Author
|
cc @sylr |
GiedriusS
requested changes
May 17, 2019
Member
GiedriusS
left a comment
GiedriusS
left a comment
There was a problem hiding this comment.
We should probably update Dockerfile.multi-stage as well and the changelog but otherwise LGTM 🎉
Contributor
|
Is it really needed ? I suppose by now all Go1.12 images already include 1.12.5. I think we just need to rebuild. |
Member
Author
|
Can we confirm that is the case? Also I would be 10x more comfortable if we would pin to single version. Otherwise we have 0 record and control of what the Golang version was when building image. That's unacceptable IMO. |
Member
|
I’d prefer exact versions as well. |
This is to mitigate potential memory allocation latency bugs: prometheus/prometheus#5524 Signed-off-by: Bartek Plotka <bwplotka@gmail.com> # Conflicts: # CHANGELOG.md
sylr
approved these changes
May 17, 2019
GiedriusS
approved these changes
May 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to mitigate potential memory allocation latency bugs: prometheus/prometheus#5524
Signed-off-by: Bartek Plotka bwplotka@gmail.com