.*: fix ineffectual assignment errors

cmd/thanos/downsample.go

@@ -260,8 +260,6 @@ func processDownsampling(ctx context.Context, logger log.Logger, bkt objstore.Bu
 
 	level.Info(logger).Log("msg", "uploaded block", "id", id, "duration", time.Since(begin))
 
-	begin = time.Now()
-
 	// It is not harmful if these fails.
 	if err := os.RemoveAll(bdir); err != nil {
 		level.Warn(logger).Log("msg", "failed to clean directory", "dir", bdir, "err", err)

cmd/thanos/main.go

@@ -144,6 +144,10 @@ func main() {
 		var closer io.Closer
 		var confContentYaml []byte
 		confContentYaml, err = tracingConfig.Content()
+		if err != nil {
+			level.Error(logger).Log("msg", "getting tracing config failed", "err", err)
+			os.Exit(1)
+		}
 
 		if len(confContentYaml) == 0 {
 			level.Info(logger).Log("msg", "Tracing will be disabled")

pkg/query/api/v1.go

@@ -289,7 +289,7 @@ func (api *API) query(r *http.Request) (interface{}, []error, *ApiError) {
 	}
 
 	// We are starting promQL tracing span here, because we have no control over promQL code.
-	span, ctx := tracing.StartSpan(r.Context(), "promql_instant_query")
+	span, ctx := tracing.StartSpan(ctx, "promql_instant_query")
 	defer span.Finish()
 
 	begin := api.now()
@@ -387,7 +387,7 @@ func (api *API) queryRange(r *http.Request) (interface{}, []error, *ApiError) {
 	}
 
 	// We are starting promQL tracing span here, because we have no control over promQL code.
-	span, ctx := tracing.StartSpan(r.Context(), "promql_range_query")
+	span, ctx := tracing.StartSpan(ctx, "promql_range_query")
 	defer span.Finish()
 
 	begin := api.now()

pkg/reloader/reloader_test.go

@@ -139,6 +139,7 @@ config:
 		}
 	}()
 	err = reloader.Watch(ctx)
+	testutil.Ok(t, err)
 	cancel()
 	g.Wait()
 	testutil.Equals(t, 2, reloads.Load().(int))

pkg/store/bucket_test.go

@@ -77,7 +77,6 @@ func TestBucketBlock_Property(t *testing.T) {
 				return false
 			} else if len(res) > 1 {
 				mint := int64(21001)
-				maxt := int64(0)
 				for i := 0; i < len(res)-1; i++ {
 					if res[i].meta.Thanos.Downsample.Resolution > maxResolution {
 						return false
@@ -88,16 +87,10 @@ func TestBucketBlock_Property(t *testing.T) {
 					if res[i].meta.MinTime < mint {
 						mint = res[i].meta.MinTime
 					}
-					if res[i].meta.MaxTime > maxt {
-						maxt = res[i].meta.MaxTime
-					}
 				}
 				if res[len(res)-1].meta.MinTime < mint {
 					mint = res[len(res)-1].meta.MinTime
 				}
-				if res[len(res)-1].meta.MaxTime > maxt {
-					maxt = res[len(res)-1].meta.MaxTime
-				}
 				if low < mint {
 					return false
 				}

pkg/store/prometheus.go

@@ -264,7 +264,7 @@ func (p *PrometheusStore) promSeries(ctx context.Context, q prompb.Query) (*prom
 	}
 
 	var data prompb.ReadResponse
-	spanUnmarshal, ctx := tracing.StartSpan(ctx, "unmarshal_response")
+	spanUnmarshal, _ := tracing.StartSpan(ctx, "unmarshal_response")
 	if err := proto.Unmarshal(decomp, &data); err != nil {
 		return nil, errors.Wrap(err, "unmarshal response")
 	}