Skip to content

Add downsampling metrics #1244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bwplotka merged 4 commits into from
Jun 12, 2019
Merged

Add downsampling metrics #1244

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6239ea0
Pass prometheus registry to downsample functions
mattrco Jun 10, 2019
081e8bc
Instrument downsample func
mattrco Jun 11, 2019
f4c0d6b
Whitespace
mattrco Jun 11, 2019
baa8819
MustRegister metrics
mattrco Jun 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Instrument downsample func
  • Loading branch information
@mattrco
mattrco committed Jun 11, 2019
commit 081e8bc60cd987c2f99c256814930d29aa98f2b4
6 changes: 6 additions & 0 deletions cmd/thanos/downsample.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import (
"github.com/go-kit/kit/log/level"
"github.com/improbable-eng/thanos/pkg/block"
"github.com/improbable-eng/thanos/pkg/block/metadata"
"github.com/improbable-eng/thanos/pkg/compact"
"github.com/improbable-eng/thanos/pkg/compact/downsample"
"github.com/improbable-eng/thanos/pkg/component"
"github.com/improbable-eng/thanos/pkg/objstore"
Expand Down Expand Up @@ -220,9 +221,12 @@ func downsampleBucket(
if m.MaxTime-m.MinTime < 40*60*60*1000 {
continue
}

if err := processDownsampling(ctx, logger, bkt, m, dir, 5*60*1000); err != nil {
metrics.downsampleFailures.WithLabelValues(compact.GroupKey(*m))
return errors.Wrap(err, "downsampling to 5 min")
}
metrics.downsamples.WithLabelValues(compact.GroupKey(*m))

case 5 * 60 * 1000:
missing := false
Expand All @@ -242,8 +246,10 @@ func downsampleBucket(
continue
}
if err := processDownsampling(ctx, logger, bkt, m, dir, 60*60*1000); err != nil {
metrics.downsampleFailures.WithLabelValues(compact.GroupKey(*m))
return errors.Wrap(err, "downsampling to 60 min")
}
metrics.downsamples.WithLabelValues(compact.GroupKey(*m))
}
}
return nil
Expand Down