Conversation
bwplotka
force-pushed
the
v0.5.0-rr
branch
2 times, most recently
from
f5ddb66 to
9fb1f3f
Compare
This was referenced Jun 21, 2019
bwplotka
force-pushed
the
v0.5.0-rr
branch
3 times, most recently
from
7bd205f to
cedf673
Compare
bwplotka
force-pushed
the
v0.5.0-rr
branch
12 times, most recently
from
04bfeda to
acf922d
Compare
bwplotka
force-pushed
the
v0.5.0-rr
branch
2 times, most recently
from
6243e4d to
4f31ca5
Compare
brancz
approved these changes
Aug 20, 2019
bwplotka
force-pushed
the
v0.5.0-rr
branch
5 times, most recently
from
ef5d17b to
a460fa6
Compare
GiedriusS
reviewed
Aug 20, 2019
bwplotka
force-pushed
the
v0.5.0-rr
branch
4 times, most recently
from
431aaf5 to
e57811c
Compare
Contributor
krasi-georgiev
left a comment
krasi-georgiev
left a comment
There was a problem hiding this comment.
Can you point me to the test that ensure a good behavior when the x-streamed-protobuf returns multi frames?
bwplotka
force-pushed
the
v0.5.0-rr
branch
2 times, most recently
from
c216e97 to
d7b4aef
Compare
Member
Author
|
@krasi-georgiev The merging multi series frame are tested in proxy code here: https://github.com/thanos-io/thanos/blob/master/pkg/store/proxy_test.go#L70 But adding more testcases. |
Member
Author
|
Started discussion on the StoreAPI Series API invariant aka |
Member
Author
|
Changed this accordingly to #1464 decision. CC @krasi-georgiev |
Fixes: #488 Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
This was referenced Sep 13, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #488
Signed-off-by: Bartek Plotka bwplotka@gmail.com