Fixes #1272: fix map concurrent writes when rendering html templates in ui#1280
Merged
povilasv merged 1 commit intothanos-io:masterfrom Jun 27, 2019
Merged
Fixes #1272: fix map concurrent writes when rendering html templates in ui#1280povilasv merged 1 commit intothanos-io:masterfrom
povilasv merged 1 commit intothanos-io:masterfrom
Conversation
lx223
changed the title
lx223
changed the title
povilasv
approved these changes
Jun 27, 2019
Member
|
This makes sense, we were writing to map concurrently. Thanks for fixing this! |
Member
|
That was quick @lx223 ! (: |
Member
|
Since we probably copied this part from Prometheus I would check Prometheus codebase as well if they have same bug 🤔 |
Member
|
Also we are missing CHANGELOG entry (: But it will be part of release shephard items to do. |
Contributor
Author
|
Ah, sorry. Should have added the entry in CHANGELOG. I'll put up another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
template.Funcsto overwrite prefix rendering function to avoid concurrent map writesVerification
Run
go run github.com/improbable-eng/thanos/cmd/thanos queryAnd then concurrently HTTP GET "http://0.0.0.0:10902/graph" 1000 times
Before change:
It panics with concurrent map writes.
After change:
No longer panics.