add CHANGELOG entry for PR #1311#1315
Merged
bwplotka merged 1 commit intothanos-io:masterfrom Jul 11, 2019
Merged
Conversation
Contributor
Author
bwplotka
reviewed
Jul 9, 2019
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
Thanks!
Can we mention what occasional means? What specifc operations were causing panics?
Contributor
Author
|
It could be many different things causing the panics, honestly. Network connectivity, Azure availability, etc. It was caused by the Azure library having a part of a function that wasn't checking the value of I could clarify that the panics would happen while downloading the "blob" to a buffer, if that helps :) |
Member
|
Ah. so let's write then |
wbh1
force-pushed
the
azure-panic-changelog
branch
from
7cda1e0 to
9548058
Compare
Contributor
Author
|
Fixed it. PS - congrats on CNCF acceptance 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds an entry to the CHANGELOG for the fix added in #1311, since I overlooked that initially 😅
Verification
N/A