Remove duplicate closing grpc listener#1322
Merged
GiedriusS merged 1 commit intothanos-io:masterfrom Jul 12, 2019
Merged
Conversation
Signed-off-by: jojohappy <sarahdj0917@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jojohappy sarahdj0917@gmail.com
Changes
Remove the code
runutil.CloseWithLogOnErr(logger, l, "store gRPC listener"), because when the grpc server is stopped, the listener who grpc server served will be closed too.Verification
Send SIGHUP to the thanos components, such as query, store, sidecar. No warning log appeared like this:
level=warn ts=2019-07-12T04:20:03.867228785Z caller=runutil.go:108 component=sidecar msg="detected close error" err="store gRPC listener: close tcp 0.0.0.0:10901: use of closed network connection"