api/series: return an empty array iff no results#1327
Merged
brancz merged 1 commit intothanos-io:masterfrom Jul 15, 2019
Merged
api/series: return an empty array iff no results#1327brancz merged 1 commit intothanos-io:masterfrom
brancz merged 1 commit intothanos-io:masterfrom
Conversation
Prometheus' /series end-point returns an empty array no matter what: if there were results or not. We need to follow the same principle in Thanos as well because our users depend on it. The same fix has been applied like here: https://github.com/prometheus/prometheus/blob/fef150f1b5e48652ec6779e2129ae9a0cf13db8a/web/api/v1/api.go#L506 Tests have been updated to account for this difference and plus one test has been added just for this case. Closes thanos-io#1325.
GiedriusS
changed the title
brancz
approved these changes
Jul 15, 2019
Member
|
Nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prometheus' /series end-point returns an empty array no matter what: if
there were results or not. We need to follow the same principle in
Thanos as well because our users depend on it.
The same fix has been applied as here:
https://github.com/prometheus/prometheus/blob/fef150f1b5e48652ec6779e2129ae9a0cf13db8a/web/api/v1/api.go#L506
Tests have been updated to account for this difference and plus one test
has been added just for this case.
Closes #1325.