receive: Store the most recent config hash and timestamp as metrics#1378
Merged
brancz merged 1 commit intothanos-io:masterfrom Aug 6, 2019
Merged
receive: Store the most recent config hash and timestamp as metrics#1378brancz merged 1 commit intothanos-io:masterfrom
brancz merged 1 commit intothanos-io:masterfrom
Conversation
Member
Author
brancz
approved these changes
Aug 6, 2019
Member
|
Nice! |
paulfantom
added a commit
to paulfantom/thanos
that referenced
this pull request
Aug 7, 2019
* master: iter.go: error message typo correction (thanos-io#1376) Fix usage of $GOPATH in Makefile (thanos-io#1379) Moved Prometheus 2.11.1 and TSDB to 0.9.1 (thanos-io#1380) Store latest config hash and timestamp as metrics (thanos-io#1378) pkg/receive/handler.go: log errors (thanos-io#1372) receive: Hash-ring metrics (thanos-io#1363) receiver: avoid race of hashring (thanos-io#1371) feat compact: added readiness Prober (thanos-io#1297) Add changelog entry for S3 option (thanos-io#1361) Multipart features (thanos-io#1358) Added katacoda.yaml (thanos-io#1359) Remove deprecated option from example (thanos-io#1351) Move suggestion about admin API to appropriate place (thanos-io#1355)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to store the most recent config md5 checksum, and when it happens as metrics to catch any inconsistencies between current and desired state. The same strategy is used by prometheus/alertmanager#coodinator.
Changes
thanos_receive_config_hash,thanos_receive_config_last_reload_successfulandthanos_receive_config_last_reload_success_timestamp_seconds.Verification
make test,make lint,make buildand manual verification of the metrics.