Skip to content

feat sicedar: added readiness prober #1395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bwplotka merged 7 commits into from
Aug 28, 2019
Merged

feat sicedar: added readiness prober #1395

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3b2d411
feat sicedar: added readiness prober
FUSAKLA Aug 10, 2019
9193da3
cr: inline the component usage
FUSAKLA Aug 14, 2019
cdc30f4
cr: refactor sidecar prober logic
FUSAKLA Aug 14, 2019
153cd3f
CR: revert to original PR logic wothout touching sidecar liveness
FUSAKLA Aug 19, 2019
d351d03
CR: removed readiness handling from periodical prometheus health checks
FUSAKLA Aug 20, 2019
60897a8
fix prober: fixed false error logging
FUSAKLA Aug 27, 2019
210075a
CR: fix prober comment to work with godoc
FUSAKLA Aug 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
CR: removed readiness handling from periodical prometheus health checks 
Signed-off-by: Martin Chodur <m.chodur@seznam.cz>
  • Loading branch information
@FUSAKLA
FUSAKLA committed Aug 20, 2019
commit d351d03eabea190cf65c36971a3be49bea5595a6
2 changes: 0 additions & 2 deletions cmd/thanos/sidecar.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,10 +187,8 @@ func runSidecar(
if err := m.UpdateLabels(iterCtx, logger); err != nil {
level.Warn(logger).Log("msg", "heartbeat failed", "err", err)
promUp.Set(0)
statusProber.SetNotReady(err)
} else {
promUp.Set(1)
statusProber.SetReady()
lastHeartbeat.Set(float64(time.Now().UnixNano()) / 1e9)
}

Expand Down