query/receive: Unify HTTP server instrumentation

[kakkoyun]

This PR attempts to unify HTTP server instrumentation behavior across components and removes unnecessary metrics. Thanos Query and Receive now use common instrumentation middleware.

PTAL #1420 for previous discussions.

Changes

• Thanos Query no longer exposes thanos_query_api_instant_query_duration_seconds, thanos_query_api_range_query_duration_second metrics.
• Thanos Receive no longer exposes thanos_http_request_duration_seconds, thanos_http_requests_total, thanos_http_response_size_bytes.

Verification

Local make test and run.

[kakkoyun]

cc @brancz @bwplotka @squat

[brancz]

Did we always forget to register this or am I missing why this line is here?

[kakkoyun]

If I understood you correctly, It was registered before. I just removed the ones which come from InstrumentationMiddleware.

thanos/pkg/receive/handler.go

Lines 112 to 119 in 8feb079

	if o.Registry != nil {
	o.Registry.MustRegister(
	h.requestDuration,
	h.requestsTotal,
	h.responseSize,
	h.forwardRequestsTotal,
	)
	}

[brancz]

Got it. Makes sense now.

[brancz]

Sorry misclicked. Didn’t mean to approve, just comment.