Choose lowest downsampling resolution with granular control.#1465
Choose lowest downsampling resolution with granular control.#1465
Conversation
Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
| }, | ||
| }, | ||
| { | ||
| query: "rate(up[5m:200s])", |
There was a problem hiding this comment.
This does not work as expected (in my mind). Step is still passed as 100 ms no matter what. cc @brian-brazil for help =D
There was a problem hiding this comment.
Based my knowledge on: https://prometheus.io/blog/2019/01/28/subquery-support/#subqueries
There was a problem hiding this comment.
The step is the one for query_range. We're not passing any hints relating to subqueries currently.
There was a problem hiding this comment.
Thanks! Will look deeper in PromQL if it's sane to actually propagate that hint & how.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
The step in query hints seems to be fixed now. The remaining issue is that we still can’t tune lookback delta for subqueries. |
3 participants
Playing with
Selectstorage.SelectParams.StepAs a follow up on this: #1431 I was experimenting with subquery + resolution in order to automatically adjust what downsampling Thanos should use. This, in theory, sounds great but looks like I don't really understand PromQL
storage.Params.Stepfield properly. Need to investigate more (is this param not propagated)?TODO:
[...:<resolution>]Signed-off-by: Bartek Plotka bwplotka@gmail.com