support Elastic APM for tracing#1482
Conversation
Signed-off-by: Wing924 <weihe924stephen@gmail.com>
|
Test failed because |
| github.com/jmespath/go-jmespath v0.0.0-20180206201540-c2b33e8439af h1:pmfjZENx5imkbgOkpRUYLnmbU7UEFbjtDA2hxJ1ichM= | ||
| github.com/jmespath/go-jmespath v0.0.0-20180206201540-c2b33e8439af/go.mod h1:Nht3zPeWKUH0NzdCt2Blrr5ys8VGpn0CEB0cQHVjt7k= | ||
| github.com/joeshaw/multierror v0.0.0-20140124173710-69b34d4ec901 h1:rp+c0RAYOWj8l6qbCUTSiRLG/iKnW3K3/QfPPuSsBt4= | ||
| github.com/joeshaw/multierror v0.0.0-20140124173710-69b34d4ec901/go.mod h1:Z86h9688Y0wesXCyonoVr47MasHilkuLMqGhRZ4Hpak= |
There was a problem hiding this comment.
..another multi error package to the family ;p
Nothing we can do, but just funny there are so many libs for a few lines code logic (:
pkg/tracing/client/factory.go
Outdated
| "strings" | ||
|
|
||
| "github.com/thanos-io/thanos/pkg/tracing/elasticapm" | ||
|
|
There was a problem hiding this comment.
Can you remove this newline and run make format? (limitation of goimports)
scripts/cfggen/main.go
Outdated
| "strings" | ||
|
|
||
| "github.com/thanos-io/thanos/pkg/tracing/elasticapm" | ||
|
|
Signed-off-by: Wing924 <weihe924stephen@gmail.com>
|
@bwplotka I fixed the code format. please review it again. |
|
Awesome. CI is clearly blocked we are working on the fix for: #1483 |
|
@bwplotka |
|
Already approved so.. why decline? (: Nice job, thanks! |
* support Elastic APM for tracing Signed-off-by: Wing924 <weihe924stephen@gmail.com> * fix docs Signed-off-by: Wing924 <weihe924stephen@gmail.com> * retry job Signed-off-by: Wing924 <weihe924stephen@gmail.com> * format code Signed-off-by: Wing924 <weihe924stephen@gmail.com>
|
@Wing924 hi, some questions about elastic_apm config. I setup a apm server in a k8s cluster, and conntect to elasticsearch, also show "You have correctly setup APM Server" in kibana apm. But there is no apm agent in kibana. something else to do? thanks. |
Signed-off-by: Wing924 weihe924stephen@gmail.com
Changes
Verification
--tracing.config 'type: ELASTIC_APM'