Rule: Fixed wrong query url in rules and alerts pages#1488
Merged
bwplotka merged 1 commit intothanos-io:masterfrom Sep 4, 2019
Merged
Rule: Fixed wrong query url in rules and alerts pages#1488bwplotka merged 1 commit intothanos-io:masterfrom
bwplotka merged 1 commit intothanos-io:masterfrom
Conversation
Signed-off-by: jojohappy <sarahdj0917@gmail.com>
Member
|
Yes! 🎉 |
FUSAKLA
approved these changes
Sep 4, 2019
bwplotka
approved these changes
Sep 4, 2019
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
Have you tested it? (:
Looks legit to me! LGTM.
Member
Author
Yes, it has been already run in my environment. |
wbh1
pushed a commit
to wbh1/thanos
that referenced
this pull request
Sep 17, 2019
Signed-off-by: jojohappy <sarahdj0917@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jojohappy sarahdj0917@gmail.com
Changes
[Bugfix]: User can not click the link of
exproralertto jump to Query ui in rule pages.Verification
Visit the rule or alert page, and try to click the link of
exproralert.