Conversation
|
Generally looks good, just some grammar and one consistency/cleanup type question. |
bwplotka
force-pushed
the
func-sharding
branch
from
2379f3f to
19bfed0
Compare
|
This is not ready - I need to rework this to simplify and focus on sharding only but explain how it can be extended for more advanced use cases if needed. |
bwplotka
force-pushed
the
func-sharding
branch
from
19bfed0 to
e568c3d
Compare
| * `<name>` | ||
| * `__block_objstore_bucket_endpoint` | ||
| * `__block_objstore_bucket_name` | ||
| * `__block_objstore_bucket_path` |
There was a problem hiding this comment.
This is a bit confusing to me. So let's say there will be a special __block_objstore_bucket_path label, how can we manipulate it?
As I understand it we will be able to configure Thanos Store gateway to filter out folders from s3?
action: drop
regex: "folder_name"
source_labels:
- __block_objstore_bucket_path
Not sure how we can we do with __block_objstore_bucket_endpoint, __block_objstore_bucket_name as they will be constant on the time?
There was a problem hiding this comment.
Yes, for now the options are limited - maybe indeed we should limit this (:
There was a problem hiding this comment.
We can talk about those details on the PR I guess.
Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
bwplotka
force-pushed
the
func-sharding
branch
from
e568c3d to
f7a0576
Compare
|
This should be good to go! |
Signed-off-by: Bartek Plotka <bwplotka@gmail.com> Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
5 participants
Signed-off-by: Bartek Plotka bwplotka@gmail.com
cc @jojohappy @mattrco @metalmatze