store: fix chunk pool memory leak#1512
Merged
GiedriusS merged 1 commit intothanos-io:masterfrom Sep 13, 2019
abursavich:pool-leak
Merged
store: fix chunk pool memory leak#1512GiedriusS merged 1 commit intothanos-io:masterfrom abursavich:pool-leak
GiedriusS merged 1 commit intothanos-io:masterfrom
abursavich:pool-leak
Conversation
Signed-off-by: Andy Bursavich <abursavich@gmail.com>
GiedriusS
approved these changes
Sep 13, 2019
Member
GiedriusS
left a comment
There was a problem hiding this comment.
Thanks for catching this, we are definitely forgetting to put the contents back into the pool here! All of the other places seem OK to me.
wbh1
pushed a commit
to wbh1/thanos
that referenced
this pull request
Sep 17, 2019
Signed-off-by: Andy Bursavich <abursavich@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I experienced a slow drip of "key does not exist" errors, presumably due to compactions, then nearly all get_range requests began to fail with "pool exhausted" errors.
Changes
Return the byte slice to the pool on error paths.
Verification
N/A