Add bucket inspect timeout flag#1533
Merged
bwplotka merged 2 commits intothanos-io:masterfrom Sep 17, 2019
jdfalk:add-bucket-inspect-timeout
Merged
Add bucket inspect timeout flag#1533bwplotka merged 2 commits intothanos-io:masterfrom jdfalk:add-bucket-inspect-timeout
bwplotka merged 2 commits intothanos-io:masterfrom
jdfalk:add-bucket-inspect-timeout
Conversation
Signed-off-by: Johnathan Falk <johnathan.falk@gmail.com>
Member
|
You marked CHANGELOG as done in the PR description template, but can't see the change ): I guess it would be nice to add an item to changelog? |
Contributor
Author
|
Crud. I updated the components doc but not the change long. Will add. |
Signed-off-by: Johnathan Falk <johnathan.falk@gmail.com>
Member
|
Thanks! |
wbh1
pushed a commit
to wbh1/thanos
that referenced
this pull request
Sep 17, 2019
* Add bucket inspect timeout. Signed-off-by: Johnathan Falk <johnathan.falk@gmail.com> * Added change log entry. Signed-off-by: Johnathan Falk <johnathan.falk@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Johnathan Falk johnathan.falk@gmail.com
Fixes #1532
Changes
Added timeout flag to bucket inspect
Verification
Built and run