rule: Add liveness and readiness probe#1538
Merged
bwplotka merged 5 commits intothanos-io:masterfrom Sep 19, 2019
Merged
Conversation
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Member
Author
|
cc @FUSAKLA |
Co-Authored-By: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
kakkoyun
force-pushed
the
probes_rule
branch
from
89b3692 to
a60659a
Compare
Member
|
One tiny thing, please add those also to the https://github.com/thanos-io/thanos/blob/master/tutorials/kubernetes-demo/manifests/thanos-ruler.yaml example so it stays up to date |
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
povilasv
approved these changes
Sep 19, 2019
bwplotka
approved these changes
Sep 19, 2019
GiedriusS
pushed a commit
that referenced
this pull request
Oct 28, 2019
* Add prober to rule Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Add changelog entry Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Update README Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Apply suggestions from code review Co-Authored-By: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Update rule tutorial Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kemal Akkoyun kakkoyun@gmail.com
This PR,
/-/healthyendpoint for liveness checks./-/readyendpoint for readiness checks.Changes
/-/healthyendpoint for liveness checks./-/readyendpoint for readiness checks.prober.Proberfor readiness and liveness endpoints.Verification
make testStarted
thanos ruleand made a request to related endpoints.thanos ruleand visitedhttp://localhost:10902/rulesto check UI.