Fix downsampling option in querier URL#1562
Conversation
obiesmans
force-pushed
the
master
branch
4 times, most recently
from
e77da40 to
dc7a329
Compare
|
Amended the pr to use camelcase and have a max_source_resolution in URL, as in the documentation. |
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
Awesome, thanks. Generally, it looks ok, just @GiedriusS comments applies. (:
Have you verified Querier and checked if it works? (:
|
Everything works, just those two comments and we should be good to go 😄 |
Signed-off-by: Olivier Biesmans <olivier.biesmans@blablacar.com>
|
Thanks a lot for the review ! Sorry I didn't reply sooner, was off for a few days. I also ran into issues where the URL params format didn't allow for empty params. |
Signed-off-by: Olivier Biesmans <olivier.biesmans@blablacar.com>
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
Generally good, last question hopefully (:
| <option value="">Auto downsampling</option> | ||
| <option selected="selected" value="0s">Only raw data</option> | ||
| <option value="auto">Auto downsampling</option> | ||
| <option value="0s">Only raw data</option> |
There was a problem hiding this comment.
Quick silly question, why we remove selected here again? It changes what is by default set, right?
There was a problem hiding this comment.
I think that which option is selected by default should be driven from the javascript only.
(same place where the other UI driving logic is).
It doesn't change, the default which is still "0s" if the parameter is not set :
https://github.com/thanos-io/thanos/pull/1562/files#diff-b1f64ac291243b832fd99d257dcb04feR47-R49
Let me know if you agree with this choice, or if I should add this back in the UI.
There was a problem hiding this comment.
Makes sense IMHO that we keep all of that logic together in that file instead of the HTML code, thanks for pointing this out!
GiedriusS
left a comment
GiedriusS
left a comment
There was a problem hiding this comment.
Played around with it and it works well. Thanks for this and sorry for the late answer!
|
Also, double-checked the "instant query" side of this - everything should work well like before and now actually the user will be able to see that they are able to change this parameter -- it was "invisible" before. |
|
Thanks a lot for taking the time to review this @GiedriusS ! |
3 participants
Fixes #1463
Changes
Verification