Skip to content

Added min-time limitaiton for sidecar. This allows optionally storing longer retention time on Prometheus.#1619

Merged
bwplotka merged 1 commit intomasterfrom
sidecar-min-time
Oct 10, 2019
Merged

Added min-time limitaiton for sidecar. This allows optionally storing longer retention time on Prometheus.#1619
bwplotka merged 1 commit intomasterfrom
sidecar-min-time

Conversation

@bwplotka
Copy link
Member

@bwplotka bwplotka commented Oct 9, 2019

Rebased and with addressed comments of this: #1267

Fixes #1191

Signed-off-by: Bartek Plotka bwplotka@gmail.com

TODO:

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

… longer retention time on Prometheus.

Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
Copy link
Member

@povilasv povilasv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome !

@bwplotka bwplotka merged commit baf0b28 into master Oct 10, 2019
@bwplotka bwplotka deleted the sidecar-min-time branch October 10, 2019 09:27
GiedriusS pushed a commit that referenced this pull request Oct 28, 2019
… longer retention time on Prometheus. (#1619)

Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sidecar: exceeded sample limit

2 participants