Fixed compactor tests; Moved to full e2e compact test; Cleaned metrics.#1666
Merged
Fixed compactor tests; Moved to full e2e compact test; Cleaned metrics.#1666
Conversation
bwplotka
requested review from
FUSAKLA,
GiedriusS,
brancz,
metalmatze and
povilasv
This was referenced Oct 18, 2019
brancz
reviewed
Oct 18, 2019
brancz
reviewed
Oct 18, 2019
Member
brancz
left a comment
brancz
left a comment
There was a problem hiding this comment.
Overall looks right, just want to avoid confusions with the metrics.
Member
Author
|
Thanks for looking into this metric "swap" @brancz - I am not 100% particularly sure if we won't confuse users, but I think what users was expecting seeing |
squat
reviewed
Oct 18, 2019
Member
squat
left a comment
squat
left a comment
There was a problem hiding this comment.
Overall LGTM, some small questions and grammar suggestions (:
GiedriusS
pushed a commit
that referenced
this pull request
Oct 28, 2019
…s. (#1666) * Fixed compactor tests; Moved to full e2e compact test; Cleaned metrics. Signed-off-by: Bartek Plotka <bwplotka@gmail.com> * Removed block after each compaction group run. Fixes: #1499 Signed-off-by: Bartek Plotka <bwplotka@gmail.com> * Moved to label hash for dir names for compactor groups. Fixes: #1661 Signed-off-by: Bartek Plotka <bwplotka@gmail.com> * Addressed comments. Signed-off-by: Bartek Plotka <bwplotka@gmail.com> * Addressed comments, rebased. Signed-off-by: Bartek Plotka <bwplotka@gmail.com> Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR is big but I recommend review commit by commit (:
Fixes: #1499
Fixes: #1661
cc @krasi-georgiev as I changed your tests (one was broken, some I moved to proper, full compact_e2e)