querier: Actually use select Start,End params during select.#1675
Merged
querier: Actually use select Start,End params during select.#1675
Conversation
bwplotka
requested review from
FUSAKLA,
GiedriusS,
brancz,
domgreen and
metalmatze
bwplotka
changed the title
Member
|
nice catch! looks good, just need to update a test, it seems. |
Member
Author
|
It was actually bug, so test helped. Should be fine now 👍 |
bwplotka
force-pushed
the
querier-store
branch
from
0e8862f to
566314b
Compare
This will definitely helps with offset queries. Same was done on cortexproject/cortex#1012 Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
bwplotka
force-pushed
the
querier-store
branch
from
566314b to
f35d0cd
Compare
brancz
approved these changes
Oct 22, 2019
Contributor
|
This is okay, as long as you're using a new enough version of Prometheus that actually sends these. |
Member
Author
|
Good point, we plan to fetch latest Prometheus soon as well. |
GiedriusS
pushed a commit
that referenced
this pull request
Oct 28, 2019
This will definitely helps with offset queries. Same was done on cortexproject/cortex#1012 Signed-off-by: Bartek Plotka <bwplotka@gmail.com> Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will definitely helps with offset queries.
Same was done on cortexproject/cortex#1012
Signed-off-by: Bartek Plotka bwplotka@gmail.com