-
Notifications
You must be signed in to change notification settings - Fork 2.3k
.*: Add support for tracing with Lightstep #1678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
401ee02
Add support for tracing with Lightstep
antonio 7e6b650
Remove type cast
antonio 4fd596a
Add documentation for the exported methods and types
antonio 1001596
Apply suggestions from @bwplotka
antonio 78bdee0
Inline variable
antonio b3ed2d1
Merge branch 'master' into lightstep-tracing
antonio 249c317
Merge remote-tracking branch 'origin/master' into lightstep-tracing
antonio d9acf6a
Update lightstep library and add proper error handling
antonio 4c44f3c
Remove unused import
antonio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| package lightstep | ||
|
|
||
| import ( | ||
| "context" | ||
| "io" | ||
|
|
||
| "github.com/lightstep/lightstep-tracer-go" | ||
| "github.com/opentracing/opentracing-go" | ||
| "gopkg.in/yaml.v2" | ||
| ) | ||
|
|
||
| // Config - YAML configuration. | ||
| type Config struct { | ||
| // AccessToken is the unique API key for your LightStep project. It is | ||
| // available on your account page at https://app.lightstep.com/account. | ||
| AccessToken string `yaml:"access_token"` | ||
|
|
||
| // Collector is the host, port, and plaintext option to use | ||
| // for the collector. | ||
| Collector lightstep.Endpoint `yaml:"collector"` | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. reusing config 👍 nice!
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 😄 |
||
| } | ||
|
|
||
| // Tracer wraps the Lightstep tracer and the context. | ||
| type Tracer struct { | ||
| lightstep.Tracer | ||
| ctx context.Context | ||
| } | ||
|
|
||
| // Close synchronously flushes the Lightstep tracer, then terminates it. | ||
| func (t *Tracer) Close() error { | ||
| t.Tracer.Close(t.ctx) | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| // NewTracer creates a Tracer with the options present in the YAML config. | ||
| func NewTracer(ctx context.Context, yamlConfig []byte) (opentracing.Tracer, io.Closer, error) { | ||
| config := Config{} | ||
| if err := yaml.Unmarshal(yamlConfig, &config); err != nil { | ||
| return nil, nil, err | ||
| } | ||
|
|
||
| options := lightstep.Options{ | ||
| AccessToken: config.AccessToken, | ||
| Collector: config.Collector, | ||
| } | ||
| lighstepTracer, err := lightstep.CreateTracer(options) | ||
| if err != nil { | ||
| return nil, nil, err | ||
| } | ||
|
|
||
| t := &Tracer{ | ||
| lighstepTracer, | ||
| ctx, | ||
| } | ||
| return t, t, nil | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.