Merged
Conversation
squat
approved these changes
Nov 15, 2019
Member
|
How many dependabot PRs are we actually merging? Do you mean keeping it enabled just to be notified about releases? It's a little noisy IMO for that :p |
Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
Member
Author
|
Not sure, we probably have to reduce the noise. In terms of release notes, I double-checked Prometheus upgrade and nothing really affecting Thanos users was merged (: |
tianyuansun
pushed a commit
to tianyuansun/thanos
that referenced
this pull request
Nov 19, 2019
Signed-off-by: Bartek Plotka <bwplotka@gmail.com> Signed-off-by: suntianyuan <suntianyuan@baidu.com>
IKSIN
pushed a commit
to monitoring-tools/thanos
that referenced
this pull request
Nov 26, 2019
Signed-off-by: Bartek Plotka <bwplotka@gmail.com> Signed-off-by: Aleksey Sin <asin@ozon.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #1659 let's update our deps at once.
Should we disable dependabot now? I will close all its PRs for now. Still, it can be nice to be updated about all new releases (:
Signed-off-by: Bartek Plotka bwplotka@gmail.com