bucket: Add --web.external-prefix for proxying on a subpath#1758
Merged
bwplotka merged 4 commits intothanos-io:masterfrom Nov 20, 2019
Merged
bucket: Add --web.external-prefix for proxying on a subpath#1758bwplotka merged 4 commits intothanos-io:masterfrom
--web.external-prefix for proxying on a subpath#1758bwplotka merged 4 commits intothanos-io:masterfrom
Conversation
Signed-off-by: Wade Rossmann <wrossmann@gmail.com>
Signed-off-by: Wade Rossmann <wrossmann@gmail.com>
wrossmann
force-pushed
the
bucket-route-prefix
branch
from
dc50069 to
78ac797
Compare
Member
|
Hey there ! Thanks for your contribution, this looks nice. Make sure to pass the linter and we'll be good to go 😄 |
adrien-f
approved these changes
Nov 19, 2019
Signed-off-by: Wade Rossmann <wrossmann@gmail.com>
wrossmann
force-pushed
the
bucket-route-prefix
branch
from
1362fee to
d84e632
Compare
bwplotka
approved these changes
Nov 20, 2019
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
LGTM, but CI is still failing.
IKSIN
pushed a commit
to monitoring-tools/thanos
that referenced
this pull request
Nov 26, 2019
…-io#1758) * bucket: Add `--web.external-prefix` for proxying on a subpath Signed-off-by: Wade Rossmann <wrossmann@gmail.com> * Update PR number from previous broken branch. Signed-off-by: Wade Rossmann <wrossmann@gmail.com> * Linter fixes Signed-off-by: Wade Rossmann <wrossmann@gmail.com> * Doc fixes Signed-off-by: Wade Rossmann <wrossmann@gmail.com> Signed-off-by: Aleksey Sin <asin@ozon.ru>
IKSIN
pushed a commit
to monitoring-tools/thanos
that referenced
this pull request
Nov 27, 2019
…-io#1758) * bucket: Add `--web.external-prefix` for proxying on a subpath Signed-off-by: Wade Rossmann <wrossmann@gmail.com> * Update PR number from previous broken branch. Signed-off-by: Wade Rossmann <wrossmann@gmail.com> * Linter fixes Signed-off-by: Wade Rossmann <wrossmann@gmail.com> * Doc fixes Signed-off-by: Wade Rossmann <wrossmann@gmail.com> Signed-off-by: Aleksey Sin <asin@ozon.ru>
IKSIN
pushed a commit
to monitoring-tools/thanos
that referenced
this pull request
Nov 27, 2019
…-io#1758) * bucket: Add `--web.external-prefix` for proxying on a subpath Signed-off-by: Wade Rossmann <wrossmann@gmail.com> * Update PR number from previous broken branch. Signed-off-by: Wade Rossmann <wrossmann@gmail.com> * Linter fixes Signed-off-by: Wade Rossmann <wrossmann@gmail.com> * Doc fixes Signed-off-by: Wade Rossmann <wrossmann@gmail.com> Signed-off-by: Aleksey Sin <asin@ozon.ru>
IKSIN
pushed a commit
to monitoring-tools/thanos
that referenced
this pull request
Nov 27, 2019
…-io#1758) * bucket: Add `--web.external-prefix` for proxying on a subpath Signed-off-by: Wade Rossmann <wrossmann@gmail.com> * Update PR number from previous broken branch. Signed-off-by: Wade Rossmann <wrossmann@gmail.com> * Linter fixes Signed-off-by: Wade Rossmann <wrossmann@gmail.com> * Doc fixes Signed-off-by: Wade Rossmann <wrossmann@gmail.com> Signed-off-by: Aleksey Sin <asin@ozon.ru>
IKSIN
pushed a commit
to monitoring-tools/thanos
that referenced
this pull request
Nov 27, 2019
…-io#1758) * bucket: Add `--web.external-prefix` for proxying on a subpath Signed-off-by: Wade Rossmann <wrossmann@gmail.com> * Update PR number from previous broken branch. Signed-off-by: Wade Rossmann <wrossmann@gmail.com> * Linter fixes Signed-off-by: Wade Rossmann <wrossmann@gmail.com> * Doc fixes Signed-off-by: Wade Rossmann <wrossmann@gmail.com> Signed-off-by: Aleksey Sin <asin@ozon.ru>
IKSIN
pushed a commit
to monitoring-tools/thanos
that referenced
this pull request
Nov 27, 2019
…-io#1758) * bucket: Add `--web.external-prefix` for proxying on a subpath Signed-off-by: Wade Rossmann <wrossmann@gmail.com> * Update PR number from previous broken branch. Signed-off-by: Wade Rossmann <wrossmann@gmail.com> * Linter fixes Signed-off-by: Wade Rossmann <wrossmann@gmail.com> * Doc fixes Signed-off-by: Wade Rossmann <wrossmann@gmail.com> Signed-off-by: Aleksey Sin <asin@ozon.ru>
IKSIN
pushed a commit
to monitoring-tools/thanos
that referenced
this pull request
Nov 27, 2019
…-io#1758) * bucket: Add `--web.external-prefix` for proxying on a subpath Signed-off-by: Wade Rossmann <wrossmann@gmail.com> * Update PR number from previous broken branch. Signed-off-by: Wade Rossmann <wrossmann@gmail.com> * Linter fixes Signed-off-by: Wade Rossmann <wrossmann@gmail.com> * Doc fixes Signed-off-by: Wade Rossmann <wrossmann@gmail.com> Signed-off-by: Aleksey Sin <asin@ozon.ru>
IKSIN
pushed a commit
to monitoring-tools/thanos
that referenced
this pull request
Nov 27, 2019
…-io#1758) * bucket: Add `--web.external-prefix` for proxying on a subpath Signed-off-by: Wade Rossmann <wrossmann@gmail.com> * Update PR number from previous broken branch. Signed-off-by: Wade Rossmann <wrossmann@gmail.com> * Linter fixes Signed-off-by: Wade Rossmann <wrossmann@gmail.com> * Doc fixes Signed-off-by: Wade Rossmann <wrossmann@gmail.com> Signed-off-by: Aleksey Sin <asin@ozon.ru>
IKSIN
pushed a commit
to monitoring-tools/thanos
that referenced
this pull request
Nov 27, 2019
…-io#1758) * bucket: Add `--web.external-prefix` for proxying on a subpath Signed-off-by: Wade Rossmann <wrossmann@gmail.com> * Update PR number from previous broken branch. Signed-off-by: Wade Rossmann <wrossmann@gmail.com> * Linter fixes Signed-off-by: Wade Rossmann <wrossmann@gmail.com> * Doc fixes Signed-off-by: Wade Rossmann <wrossmann@gmail.com> Signed-off-by: Aleksey Sin <asin@ozon.ru>
IKSIN
pushed a commit
to monitoring-tools/thanos
that referenced
this pull request
Nov 27, 2019
…-io#1758) * bucket: Add `--web.external-prefix` for proxying on a subpath Signed-off-by: Wade Rossmann <wrossmann@gmail.com> * Update PR number from previous broken branch. Signed-off-by: Wade Rossmann <wrossmann@gmail.com> * Linter fixes Signed-off-by: Wade Rossmann <wrossmann@gmail.com> * Doc fixes Signed-off-by: Wade Rossmann <wrossmann@gmail.com> Signed-off-by: Aleksey Sin <asin@ozon.ru>
fatsheep9146
pushed a commit
to fatsheep9146/thanos
that referenced
this pull request
Dec 4, 2019
…-io#1758) * bucket: Add `--web.external-prefix` for proxying on a subpath Signed-off-by: Wade Rossmann <wrossmann@gmail.com> * Update PR number from previous broken branch. Signed-off-by: Wade Rossmann <wrossmann@gmail.com> * Linter fixes Signed-off-by: Wade Rossmann <wrossmann@gmail.com> * Doc fixes Signed-off-by: Wade Rossmann <wrossmann@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
--web.external-prefixtothanos bucket webto support proxying on a subpath.thanos bucket web --helpoutput.Verification
Built clean, worked as expected locally.