Re-adjust histogram buckets#1769
Merged
bwplotka merged 1 commit intothanos-io:masterfrom Nov 20, 2019
Merged
Conversation
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Member
Author
|
cc @bwplotka |
bwplotka
approved these changes
Nov 20, 2019
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
Thanks! This is a much better distribution IMO (:
squat
approved these changes
Nov 20, 2019
IKSIN
pushed a commit
to monitoring-tools/thanos
that referenced
this pull request
Nov 26, 2019
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> Signed-off-by: Aleksey Sin <asin@ozon.ru>
IKSIN
pushed a commit
to monitoring-tools/thanos
that referenced
this pull request
Nov 27, 2019
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> Signed-off-by: Aleksey Sin <asin@ozon.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR re-adjusts histogram buckets, as a follow-up to #1545.
Re-adjust smaller low latency buckets and limits maximum bucket size to default query timeout limit for read path.
Signed-off-by: Kemal Akkoyun kakkoyun@gmail.com
Changes
Verification
make test-localMINIO_ENABLED=1 ./scripts/quickstart.shandcurl /metrics.