Skip to content

Update rule UI#1854

Merged
bwplotka merged 3 commits intothanos-io:masterfrom
yeya24:update-rule-ui
Dec 10, 2019
Merged

Update rule UI#1854
bwplotka merged 3 commits intothanos-io:masterfrom
yeya24:update-rule-ui

Conversation

@yeya24
Copy link
Contributor

@yeya24 yeya24 commented Dec 9, 2019

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Sync with the classic Prometheus UI alerts page. Enable to display the alerts counts and filter by alert state.

Verification

image

Signed-off-by: yeya24 <yb532204897@gmail.com>
Signed-off-by: yeya24 <yb532204897@gmail.com>
@yeya24 yeya24 changed the title Update rule UI with Prometheus Update rule UI Dec 9, 2019
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add CHANGELOG and LGTM (:

Thanks for this!

Signed-off-by: yeya24 <yb532204897@gmail.com>
@yeya24
Copy link
Contributor Author

yeya24 commented Dec 9, 2019

@bwplotka Done

Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bwplotka bwplotka merged commit e94478c into thanos-io:master Dec 10, 2019
@yeya24 yeya24 deleted the update-rule-ui branch December 10, 2019 01:31
@yeya24 yeya24 mentioned this pull request Jan 25, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants