add user-agent in http header.#1867
Merged
bwplotka merged 1 commit intothanos-io:masterfrom Dec 11, 2019
Merged
Conversation
Signed-off-by: johncming <johncming@yahoo.com>
GiedriusS
approved these changes
Dec 11, 2019
Member
GiedriusS
left a comment
GiedriusS
left a comment
There was a problem hiding this comment.
It seems like a nice improvement! This also makes sure we follow the same convention that Prometheus does when sending an alert. Thank you.
Member
|
Would be nice to have CHANGELOG for this (: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add user-agent in http header.