packaging alertmanager sets and add a tests.#1894
Closed
johncming wants to merge 2 commits intothanos-io:masterfrom
Closed
packaging alertmanager sets and add a tests.#1894johncming wants to merge 2 commits intothanos-io:masterfrom
johncming wants to merge 2 commits intothanos-io:masterfrom
Conversation
Signed-off-by: johncming <johncming@yahoo.com>
johncming
force-pushed
the
abstract-alertmanager
branch
from
1269404 to
d34701d
Compare
Member
|
Hi, Thanks for looking into this and please be aware of this work: #1838 which changes a lot and adds tests as well (: |
Member
|
Can you rebase? (: |
Contributor
Author
Yes. |
Contributor
|
@johncming the code has evolved a lot on the |
|
This issue/PR has been automatically marked as stale because it has not had recent activity. Please comment on status otherwise the issue will be closed in a week. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
packaging alertmanager sets and add a tests.