Skip to content

scripts/build-check-comments.sh: fix exit code #1907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
squat merged 1 commit into from
Dec 18, 2019
Merged

scripts/build-check-comments.sh: fix exit code #1907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/store/tsdb_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ func TestTSDBStore_LabelNames(t *testing.T) {
{
title: "add another label",
labels: []string{"bar", "bar"},
// we will get two labels here
// We will get two labels here.
expectedNames: []string{"bar", "foo"},
},
} {
Expand Down
5 changes: 4 additions & 1 deletion scripts/build-check-comments.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,12 +94,15 @@ function check_comments {
# option is used and a selected line is found.
if test "0" == "${res}" # found something
then
printf "\n\n\n Error: Found comments without trailing period. Comments has to be full sentences.\n\n\n."
printf "\n\n\n Error: Found comments without trailing period. Comments has to be full sentences.\n\n\n"
exit 1
elif test "1" == "${res}" # nothing found, all clear
then
printf "\n\n\n All comment formatting is good, Spartan.\n\n\n"
exit 0
else # grep error
printf "\n\n\n Hmmm something didn't work, issues with grep?.\n\n\n"
exit 2
fi
}

Expand Down