Fixed the compactor successfully exiting when actually an error occurred while compacting a blocks group#1931
Merged
bwplotka merged 1 commit intothanos-io:masterfrom Jan 2, 2020
Conversation
…red while compacting a blocks group Signed-off-by: Marco Pracucci <marco@pracucci.com>
GiedriusS
approved these changes
Dec 31, 2019
Member
GiedriusS
left a comment
GiedriusS
left a comment
There was a problem hiding this comment.
Seems like an obvious fix in the logic here to me, not sure if any tests are needed here.
bwplotka
approved these changes
Jan 2, 2020
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
Yup, thanks for spotting and fixing! <3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are conditions under which the
BucketCompactor.Compact()returns no error even if an error occurred.This happens when the number of groups left to compact is <= the concurrency. In this scenario, all jobs have been pushed to workers, so the code executions moves to
wg.Wait()and any subsequent error is not catched and then returned.Changes
Verification
Manual tests.