*: support Alertmanager API v2#1982
Merged
GiedriusS merged 2 commits intothanos-io:masterfrom Jan 14, 2020
Merged
Conversation
simonpasquier
force-pushed
the
support-api-v2-alertmanager
branch
from
c80c7bc to
26a9da5
Compare
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
simonpasquier
force-pushed
the
support-api-v2-alertmanager
branch
from
26a9da5 to
ffc6d7b
Compare
GiedriusS
approved these changes
Jan 13, 2020
Member
GiedriusS
left a comment
GiedriusS
left a comment
There was a problem hiding this comment.
Some very small things but otherwise looks good to me! Thanks!
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
GiedriusS
approved these changes
Jan 14, 2020
Contributor
Author
|
Thanks! |
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added a new parameter to the alerting configuration similar to what we have in the Prometheus configuration.
Verification
End-to-end tests modified to verify both v1 and v2 endpoints.