api/v1: add cache-control header#1984
Merged
GiedriusS merged 3 commits intothanos-io:masterfrom Jan 13, 2020
Merged
Conversation
Let's set `Cache-Control` to `no-store` if there were any warnings while the query was being executed i.e. it is a partial response or we got some other problem. Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
squat
approved these changes
Jan 13, 2020
Member
|
We can't merge it, until you undraft it (: |
Member
Author
I know, didn't expect such positive responses and I wasn't fast enough 😄 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's set
Cache-Controltono-storeif there were any warnings whilethe query was being executed i.e. it is a partial response or we got
some other problem.
Seems like this works successfully in tandem with cortexproject/cortex#1974.
Tested by turning off one sidecar which leads to warnings and then Cortex Query Frontend did not save anything into the cache when querying.
Signed-off-by: Giedrius Statkevičius giedriuswork@gmail.com