Add _total suffix to two counter metrics#2021
Merged
bwplotka merged 1 commit intothanos-io:masterfrom Jan 23, 2020
Merged
Conversation
FUSAKLA
approved these changes
Jan 22, 2020
Member
FUSAKLA
left a comment
FUSAKLA
left a comment
There was a problem hiding this comment.
Ok with me, just better to put it to changelog, so we don't forget update the mixins once released maybe?
bwplotka
approved these changes
Jan 22, 2020
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
It is almost even mandatory to put change log AND change jsonnet in same PR so it won't get lost (:
Thanks for doing this, you are amazing @yeya24
We are having some conference week but we should be more active in reviewing next week, sorry for delays!
Contributor
Author
|
Sure. I will add the changelog. But I didn't find any related rules in the mixin. And couldn't find that in the kube-thanos repo as well |
Signed-off-by: yeya24 <yb532204897@gmail.com>
yeya24
force-pushed
the
rename-counter
branch
from
308b06c to
636f9c8
Compare
bwplotka
approved these changes
Jan 23, 2020
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
If there is no alert/rule/dashboard related then it's fine 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yeya24 yb532204897@gmail.com
Changes
I guess we need
_totalin counter metricsVerification