Pass prom registry to shipper from ruler.#2051
Merged
squat merged 2 commits intothanos-io:masterfrom Jan 28, 2020
Merged
Conversation
OGKevin
changed the title
bwplotka
approved these changes
Jan 28, 2020
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
LGTM 👍 Just DCO is failing (: Click on DCO bot to see why.
thanos-io#2050 Fixes thanos-io#2050 Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>
thanos-io#2050 Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>
OGKevin
force-pushed
the
pass-registry-to-shipper-#2050
branch
from
821e454 to
e12ef85
Compare
Contributor
Author
|
@bwplotka Its ready for review now 😊 |
bwplotka
approved these changes
Jan 28, 2020
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Thanks for CHANGELOG as well 👍
squat
approved these changes
Jan 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2050
Fixes #2050
Changes
Verification