Skip to content

Gracefully handle additional oneof fields in SeriesResponse #2501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bwplotka merged 3 commits into from
Apr 22, 2020
Merged

Gracefully handle additional oneof fields in SeriesResponse #2501

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80b5422
Gracefully handle additional oneof fields in SeriesResponse
pracucci Apr 22, 2020
cf834e9
Removed unnecessary continue
pracucci Apr 22, 2020
b6d9741
Updated CHANGELOG
pracucci Apr 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed unnecessary continue 
Signed-off-by: Marco Pracucci <marco@pracucci.com>
  • Loading branch information
@pracucci
pracucci committed Apr 22, 2020
commit cf834e9891c341409dbf7f61667a519e30579249
2 changes: 0 additions & 2 deletions pkg/store/proxy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,6 @@ func startStreamSeriesSet(

if w := rr.r.GetWarning(); w != "" {
s.warnCh.send(storepb.NewWarnSeriesResponse(errors.New(w)))
continue
}

if series := rr.r.GetSeries(); series != nil {
Expand All @@ -442,7 +441,6 @@ func startStreamSeriesSet(
s.handleErr(errors.Wrapf(ctx.Err(), "failed to receive any data from %s", s.name), done)
return
}
continue
}
}
}()
Expand Down