cmd: rule: do not wrap reload endpoint with '/'#2515
Closed
GiedriusS wants to merge 2 commits intothanos-io:masterfrom
Closed
cmd: rule: do not wrap reload endpoint with '/'#2515GiedriusS wants to merge 2 commits intothanos-io:masterfrom
GiedriusS wants to merge 2 commits intothanos-io:masterfrom
Conversation
Do not wrap the router with `/` on the `/-/reload` endpoint. Otherwise, it is inaccessible when no prefix has been specified by the user. Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
Contributor
|
LGTM. Shouldn't it be against |
Member
Author
I haven't checked whether this bug was introduced in 0.12 before creating this, sorry. But either order should work albeit with more effort on the person who is doing the release. I'm fine with reopening it to a different branch. @squat care to take a look? |
Contributor
|
Should we add a test for reload that it picks up new rules, wdyt? |
Member
|
@GiedriusS let's make this PR to the release-0.12 branch to we can cut a 0.12.2 with this fix in it, yeah? |
Member
|
👍 Some e2e test for rule reload would be nice indeed. |
Member
Author
|
👍 I will open up a PR against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not wrap the router with
/on the/-/reloadendpoint. Otherwise,it is inaccessible when no prefix has been specified by the user.
Fixes #2514.
Signed-off-by: Giedrius Statkevičius giedriuswork@gmail.com