.*: pkg/tracing: Disable Elastic APM default tracer#2614
Merged
bwplotka merged 2 commits intothanos-io:masterfrom May 18, 2020
Merged
.*: pkg/tracing: Disable Elastic APM default tracer#2614bwplotka merged 2 commits intothanos-io:masterfrom
bwplotka merged 2 commits intothanos-io:masterfrom
Conversation
Sayrus
force-pushed
the
close-elastic-apm-default-tracer
branch
3 times, most recently
from
e6651f2 to
d0da235
Compare
GiedriusS
approved these changes
May 17, 2020
Member
GiedriusS
left a comment
GiedriusS
left a comment
There was a problem hiding this comment.
Yuck, thanks for this! LGTM. Could you please rebase on master? I think we should not note this as a breaking change since this was never documented and there is a proper way to load a tracer configuration into Thanos that it supposed to be used.
Disable Elastic APM Default Tracer that would otherwise gather metrics and send them on localhost even if no tracing backend was specified. Fix thanos-io#2610 Signed-off-by: Mathis Raguin <mathis@cri.epita.fr>
Sayrus
force-pushed
the
close-elastic-apm-default-tracer
branch
from
d0da235 to
28eccfa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable Elastic APM Default Tracer that would otherwise gather metrics
and send them on localhost even if no tracing backend was specified.
Fix #2610
I don't think the change is relevant as I don't see anyone using the default metric gatherer without enabling tracing. However feel free to edit it if you think the new behavior is considered breaking changes.
The worse case scenario is: someone is using the default gatherer to gather Go Metrics without having tracing enabled. As far as I understand it, this is undocumented and unsupported.
Changes
Disable Elastic APM default tracer on initialization
Verification
Start
thanoswithELASTIC_APM_LOG_LEVEL=debugandELASTIC_APM_LOG_FILE=stdout. Elastic APM does not try to gather and send metrics anymore.