Upgrade Prometheus to master#2658
Conversation
Signed-off-by: Marco Pracucci <marco@pracucci.com>
| h, err := tsdb.NewHead(nil, nil, nil, 1, tsdb.DefaultStripeSize) | ||
| h, err := tsdb.NewHead(nil, nil, nil, 1, dir, nil, tsdb.DefaultStripeSize, nil) | ||
| testutil.Ok(t, err) | ||
| defer testutil.Ok(t, h.Close()) |
There was a problem hiding this comment.
I wonder how did this not cause an issue before 😮
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
| # don't limit this to the number of allocated cores, the job is | ||
| # likely to get OOMed and killed. | ||
| GOOPTS: "-p 2" | ||
| GOOPTS: "-p 1" |
There was a problem hiding this comment.
I further reduced it because make lint was failing this way:
https://circleci.com/gh/thanos-io/thanos/9391
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
Delete mmapped chunks after creating block from head
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
Awesome, just linter issues I guess.
LGTM, anything to report on CHANGELOG? 🤔
pkg/store/postings_codec_test.go
Outdated
|
|
||
| func TestDiffVarintCodec(t *testing.T) { | ||
| h, err := tsdb.NewHead(nil, nil, nil, 1000, tsdb.DefaultStripeSize) | ||
| h, err := tsdb.NewHead(nil, nil, nil, 1000, "", nil, tsdb.DefaultStripeSize, nil) |
There was a problem hiding this comment.
the chunk directory should be a temp dir, will push a fix
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
Update CHANGELOG and unit test
|
Updated the changelog, linter seems to get killed arbitrarily but with a higher chance of getting killed |
|
Well @codesome is an OOM. I have an idea, we could make a linting in GH action instead, those might be more capable, but let's looks on that next PR. |
|
I will look on that today |
|
Can we re-run this and hope for this to be green to unblock this PR? :) I saw that it was green a while ago |
|
I can merge even and fix master then, happy with that. |
3 participants
Changes
In Cortex we're currently blocked by Prometheus update. In this PR I'm attempting an update like @krasi-georgiev correctly did in in #2633, without reworking the
FlushableStorageto hopefully get it in a mergeable state quicker 🤞Verification
Tests.