Removed legacy index.cache.json support#2667
Merged
bwplotka merged 2 commits intothanos-io:masterfrom May 28, 2020
Merged
Conversation
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
force-pushed
the
remove-index-cache-json-support
branch
from
4981d5c to
398983b
Compare
Member
|
Thanks! |
thisisobate
pushed a commit
to thisisobate/thanos
that referenced
this pull request
Jun 1, 2020
* Removed legacy index.cache.json support Signed-off-by: Marco Pracucci <marco@pracucci.com> * Added CHANGELOG entry Signed-off-by: Marco Pracucci <marco@pracucci.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
After a brief discussion on Slack, in this PR I'm proposing to completely remove the legacy
index.cache.jsonsupport, considering the binary index header is no longer experimental sincev0.12.A part from some code cleanup, the primary benefit is no longer generating the
index.cache.jsonduring compaction.Verification
Existing tests.